feat: golang attestor #426
Open
+400
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaosinthecrd <[email protected]>
version Signed-off-by: chaosinthecrd <[email protected]>
kairoaraujo
reviewed
Jan 29, 2025
| } | ||
|
|
||
| // NOTE: to get the average we need to divide by the number of packages | ||
| totalCoverage = totalCoverage / float64(len(a.Packages)) |
There was a problem hiding this comment.
If a package is empty would it divide by zero?
Maybe we can avoid it
Suggested change
| totalCoverage = totalCoverage / float64(len(a.Packages)) | |
| if len(a.Packages) > 0 { | |
| totalCoverage = totalCoverage / float64(len(a.Packages)) | |
| } else { | |
| totalCoverage = 0 | |
| } |
Co-authored-by: Kairo Araujo <[email protected]> Signed-off-by: Tom Meadows <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR introduces a golang attestor (requires go 1.24) which produces a structured golang attestation for the output of go test. Specifically, this attestor leverages the
-jsonoutput supported in Go 1.24 if it is written to a file (e.g.,go test -json -v -cover ./... > go.json) and can also leverage code coverage statements (reporting percentage coverage) if-coveris specified.Acceptance Criteria Met